[ruby - main] Upgrade rubocop to version 1.1.0 #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 1.0.0 → ~> 1.1.0) · Repo · Changelog
Release Notes
1.1.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 52 commits:
Cut 1.1Update ChangelogPrevent Lint/LiteralInInterpolation from removing necessary interpolation[Fix #8948] Fix autocorrection for Style/RedundantRegexpCharacterClass with %r[Fix #8950] Add `IgnoredMethods` and `IgnoredClasses` to `Lint/NumberConversion` (#8956)Tweak default changelog entryUse `public_send` instead of `send` when public sendableFix some issues in `Lint/UnModifiedReduceAccumulator` (#8949)Add `Regexp::Expression#loc` and `#expression` to replace `parsed_tree_expr_loc`Store parsed regexp in Node.Merge pull request #8957 from marcandre/comp_docrefactor layout specs to use `expect_offense` (#8936)Support arguments forwarding in `Lint/ToEnumArguments` cop (#8961)Improve doc for MultipleComparisonAdd `AllowMethodComparison` option for `Lint/MultipleComparison`Add new `Style/DocumentDynamicEvalDefinition` copMerge pull request #8951 from koic/support_autocorrection_for_style_multiple_comparisonAdd new `Lint/ToEnumArguments` copSupport auto-correction for `Style/MultipleComparison`Merge pull request #8939 from koic/accept_method_calls_for_style_multiple_comparisonMerge pull request #8943 from koic/update_doc_for_flip_flopAdd new `Lint/DuplicateRegexpCharacterClassElement` cop (#8896)Optimize memory usage[Fix #8708] Fix bad regexp recognition in `Lint/OutOfRangeRegexpRef` when there are multiple regexps.Improved offense message for `Lint/OutOfRangeRegexpRef`Fix changelog task to build a correct changelog item when [Fix #123] is encountered.Added additional checks to changelog specsCopy and adapt spec from rubocop-astUpdate doc for `Lint/FlipFlop`Fix autocorrection for `Layout/TrailingWhitespace` in heredocs.Fix changelog task [ci skip]Add new `Style/SwapValues` copMerge pull request #8942 from eugeneius/def_end_alignment_anonymous_moduleAdd test for anonymous module with private methodAccept method calls for `Style/MultipleComparison`[Fix #8859] Add new `Lint/UnmodifiedReduceAccumulator` cop.Add rake tasks for alternative way to specify Changelog entriesMerge pull request #8933 from matthieugendreau/fix_an_error_for_layout_empty_lines_around_access_modifierFix an error for Layout/EmptyLinesAroundAccessModifierUpdate conservative Gemfile version lock for docTweak the changelogFix a false positives for `Bundler/DuplicatedGem` when a gem conditionally duplicated within `if-elsif` or `case-when` statementsMerge pull request #8928 from koic/require_rubocop_ast_to_1_0_1[Fix #8919] Require RuboCop AST to 1.0.1 or higherMerge pull request #8922 from fatkodima/fix-disabling-copsFix rubocop comment directives handling of cops with multiple levels in department nameFix an incorrect auto-correct for `Style/RedundantRegexpCharacterClass` due to quantifierRemove `save_screenshot` from `Lint/Debugger` (revival)Merge pull request #7646 from koic/add_style_arguments_forwarding[Fix #7549] Add `Style/ArgumentsForwarding` copAdd new `Lint/EmptyBlock` copSwitch back the docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands