-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing help_text_text translations #1888
Fix missing help_text_text translations #1888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I think we should fix this at the root cause of the issues instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This is a good change. Would you please add a test for the change to the lib/resource.rb
class? The view does not need a spec.
@gr8bit I would like to add this to the 5.0 release as this breaks for all sites not having the translations in place, but a browser with non-English locale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Fixes missing method exception for html_safe on missing hint translations. Also allows setting
hint: false
inelements.yml
(e.g. while development).Checklist