Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow importing to a different port #1747

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Allow importing to a different port #1747

merged 1 commit into from
Mar 18, 2020

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Mar 18, 2020

What is this pull request for?

This allows me to import to a database running on port 12345, which I
sometimes do need.

Notable changes (remove if none)

Port is now respected when importing

Screenshots

Remove if no visual changes have been made.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

tvdeyen
tvdeyen approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, but could be ported to capistrano-alchemy, as this is the only gem using this code IIRC

@tvdeyen
Copy link
Member

tvdeyen commented Mar 18, 2020

@mamhoff mind rebasing?

@mamhoff
Allow importing to a different port
b551d51 
This allows me to import to a database running on port 12345, which I
sometimes do need.
@mamhoff mamhoff force-pushed the allow-postgres-port branch from 1e80a71 to b551d51 Compare March 18, 2020 13:21
@tvdeyen tvdeyen merged commit 2d5da13 into AlchemyCMS:master Mar 18, 2020
@tvdeyen
Copy link
Member

tvdeyen commented Mar 18, 2020

@mamhoff would you mind to work on moving the db.rake tasks into capistrano-alchemy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamhoff @tvdeyen