fix render_menu for custom controllers
#1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
render_menu for custom controllersrender_menu for custom controllers
render_menu for custom controllersrender_menu for custom controllers
tvdeyen
reviewed
Mar 18, 2020
There was a problem hiding this comment.
Is there any failing test case you could provide?
As for the testing infrastructure: The dummy app has custom controllers and models (Event and Location). Feel free to add another custom controller that reproduces the issue right in the dummy app.
Hopefully a rebase with latest master fixes the test issues
houndci-bot
reviewed
Mar 18, 2020
tvdeyen
reviewed
Mar 18, 2020
without the explicit path the current controller name will be prepended to the view path
tvdeyen
approved these changes
Mar 18, 2020
tvdeyen
pushed a commit
that referenced
this pull request
Mar 30, 2020
Without the explicit path the current controller name will be prepended to the view path.
tvdeyen
added a commit
that referenced
this pull request
Mar 30, 2020
- Sortable menus [#1758](#1758) ([mamhoff](https://github.com/mamhoff)) - Programmatic menus [#1756](#1756) ([mamhoff](https://github.com/mamhoff)) - Fix syntax in non-erb Menu templates [#1751]((#1751)) ([Alexander ADAM](https://github.com/alexanderadam)) - Fix `render_menu` for custom controllers [#1746]((#1746)) ([Alexander ADAM](https://github.com/alexanderadam))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
without
partial:the current controller name will be prepended to theview path.
Checklist
testdependencyEDIT: Sorry, I guess I misnamed it. It seems to be working within a custom controller. It does not work within devise controllers.