Menu sorting #1723
Closed
Menu sorting #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Feb 16, 2020
There was a problem hiding this comment.
Thanks, but I would like to not to use the same implementation we currently have in the page tree. It is very hard to maintain, uses an old unmaintained jquery plugin and is a performance nightmare.
I need to think about this a little bit.
But thanks for the contribution
|
Menu handling is a very useful feature, but sorting and rearranging is really needed, so I'll just use my branch then. 'Performance nightmare' means the create_tree method? Do you have any candidates instead of jquery sortable? |
|
No. Not yet. Probably something without jQuery.
|
|
http://sortablejs.github.io/Sortable/#nested This one looks most promising until now. |
|
Superseded by #1758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Makes menu elements sortable similar to pages.