Only return visible elements from Elements nested_elements relation #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have scopes on the element.nested_elements relation that makes it impossible to get all nested elements from an element.
We already excluded trashed elements from element.nested_elements relation. We should not include hidden elements as well. Closes AlchemyCMS#1587
The available scope is now the default scope for Elements nested_elements relation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Only return visible elements from
Elementsnested_elementsrelation.Before we only return not trashed elements, but as discussed in #1587 is is very confusing to have hidden elements returned as well.
Closes #1587
Notable changes
This now always return not-trashed and visible elements from
element.nested_elementscalls. If - for any reason - you want to have all elements (even trashed and invisible elements) you have to use the newly introducedall_nested_elementsrelation.