Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Ransack 1.x #1579

Merged
merged 1 commit into from
May 7, 2019
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 6, 2019

Ransack 2.0 has no breaking changes for us. The only breaking change was the removal of Rails 4.2 support, which we do not support anyways.

In order to allow to use Alchemy >= 4.1 with Solidus < 2.7 we need to still support Ransack 1.x

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@tvdeyen
Copy link
Member Author

tvdeyen commented May 7, 2019

Build error will be fixed by #1581

Ransack 2.0 has no breaking changes for us. The only breaking change was the removal of Rails 4.2 support, which we do not support anyways.

In order to allow to use Alchemy >= 4.1 with Solidus < 2.7 we need to still support Ransack 1.x
@tvdeyen tvdeyen force-pushed the allow-ransack-1.x branch from 21dd7aa to 568bc1c Compare May 7, 2019 10:20
@tvdeyen tvdeyen merged commit 032e060 into AlchemyCMS:4.1-stable May 7, 2019
@tvdeyen tvdeyen deleted the allow-ransack-1.x branch May 7, 2019 11:06
@tvdeyen tvdeyen mentioned this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants