Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Controller: Allow overriding authorize_resource #1281

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jul 29, 2017

In a host app, I want to use scopes as resource models for index actions.
Scopes can not be authorized through CanCanCan like actual models can.

This is a pretty remote use case, so I won't try baking that into the
already pretty complex resource handling system. However, it would be
convenient to be able to override the authorization logic from my host app.
This commit achieves that.

In a host app, I want to use scopes as resource models for index actions.
Scopes can not be authorized through CanCanCan like actual models can.

This is a pretty remote use case, so I won't try baking that into the
already pretty complex resource handling system. However, it would be
convenient to be able to override the authorization logic from my host app.
This commit achieves that.
@mamhoff mamhoff requested a review from tvdeyen July 29, 2017 10:19
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mamhoff mamhoff merged commit 41acc37 into AlchemyCMS:master Jul 29, 2017
@mamhoff mamhoff deleted the allow-override-resource-authorize branch July 29, 2017 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants