Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page link in TinyMCE editor instances is broken. #2500

Closed
tvdeyen opened this issue Jun 29, 2023 · 4 comments · Fixed by #2504
Closed

Page link in TinyMCE editor instances is broken. #2500

tvdeyen opened this issue Jun 29, 2023 · 4 comments · Fixed by #2504
Assignees

Comments

@tvdeyen
Copy link
Member

tvdeyen commented Jun 29, 2023

          This broke the page link in TinyMCE editor instances.

Originally posted by @tvdeyen in #2439 (comment)

@tvdeyen tvdeyen self-assigned this Jun 29, 2023
@tvdeyen
Copy link
Member Author

tvdeyen commented Jun 30, 2023

We need to revert the change made in #2439. I totally forgot that we return all pages from the API on purpose. As already discussed in #2258

The actual issue was introduced in c98605a where we started to scope the pages to the language again. I will revert this change as well.

tvdeyen referenced this issue Jun 30, 2023
We were missing a third argument in order to be able to use this
permission with the `.accessible_by` scope.
tvdeyen added a commit to tvdeyen/alchemy_cms that referenced this issue Jun 30, 2023
This fixes an issue introduced in c98605a

Closes AlchemyCMS#2500
@dbwinger
Copy link
Contributor

@tvdeyen my only concern with this is to make sure that everywhere we have a page selector, it is showing the site and language along with the page name/title, which I think is already the case. I have multiple sites mirroring the same content in different languages/regions, which means some page name duplication. I need to know which one I'm linking to.

@tvdeyen
Copy link
Member Author

tvdeyen commented Jun 30, 2023

@dbwinger yes, this is the case. We have a jQuery plugin alchemyPageSelect that uses a Handlebars template to render the result. In that we display all necessary information. If not, please open a PR/issue.

@dbwinger
Copy link
Contributor

dbwinger commented Jun 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants