Exception raised when boolean ingredient is used for element preview text

[robinboening]

Steps to reproduce

1. Create element with boolean ingredient (used for "preview text")
2. Throw this element on a Page

Expected behavior

In the elements list, the element's header part should render "true".

Actual behavior

Error is raised: Exception: undefined method `empty?' for true:TrueClass

The error is raised inside the sanitize helper as true is passed and boolean type can not be handled.
See https://github.com/AlchemyCMS/alchemy_cms/blob/main/app/views/alchemy/admin/elements/_header.html.erb#L18

A quick fix is to always cast the value to string when passing it to sanitize.

System configuration

• Alchemy Version: 6.0.3
• Rails Version: 6.1

[tvdeyen]

Hey. Could it be that the translation of the essence boolean is not a String, but cast to a Boolean instead?

alchemy_cms/app/models/alchemy/ingredients/boolean.rb

Lines 16 to 18 in 025e011

	def preview_text(_max_length = nil)
	Alchemy.t(value, scope: "ingredient_values.boolean")
	end

[robinboening]

Hey. Could it be that the translation of the essence boolean is not a String, but cast to a Boolean instead?

Good point, that's the issue indeed. The en.yml provided by alchemy_cms contains ingredient_values.boolean, while the locale files in alchemy_i18n do not.

It means it currently works in english, but not in any other language.

[tvdeyen]

Ok. This is an issue of alchemy_i18n then?

[github-actions]

This issue has not seen any activity in a long time.
Please create a pull request with a fix or ask someone of the community if they can help.
This issue will be closed in 7 days if no further activity happens.

[tvdeyen]

Maybe we cast the preview_text value to string before passing to I18n?

[tvdeyen]

@robinboening fixed by #2367