Merge pull request #2383 from mamhoff/document-links-with-format

Always provide format with attachment URLs
AlchemyCMS · Nov 18, 2022 · ea1f617 · ea1f617
2 parents f99cef5 + ea99ab0
commit ea1f617
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/app/models/alchemy/attachment/url.rb b/app/models/alchemy/attachment/url.rb
@@ -23,6 +23,7 @@ def initialize(attachment)
       # @return [String]
       #
       def call(options = {})
+        options[:format] ||= @attachment.suffix
         if options.delete(:download)
           routes.download_attachment_path(@attachment, options)
         else

diff --git a/spec/models/alchemy/attachment_spec.rb b/spec/models/alchemy/attachment_spec.rb
@@ -63,14 +63,14 @@ module Alchemy
         let(:attachment) { create(:alchemy_attachment) }
 
         it "returns local path" do
-          is_expected.to eq "/attachment/#{attachment.id}/show"
+          is_expected.to eq "/attachment/#{attachment.id}/show.png"
         end
 
         context "with download enabled" do
           subject { attachment.url(download: true) }
 
           it "returns local download path" do
-            is_expected.to eq "/attachment/#{attachment.id}/download"
+            is_expected.to eq "/attachment/#{attachment.id}/download.png"
           end
 
           context "with extra params given" do
@@ -88,7 +88,7 @@ module Alchemy
           subject { attachment.url(download: false) }
 
           it "returns local path" do
-            is_expected.to eq "/attachment/#{attachment.id}/show"
+            is_expected.to eq "/attachment/#{attachment.id}/show.png"
           end
 
           context "with extra params given" do