Fix Reachability Safety #3684
Merged
Fix Reachability Safety #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
#3676
Goals ⚽
This PR updates our integration of
SCNetworkReachabilityContextto use a weak box class and fully integrate with the framework's retain and release closures. This follows the same logic as Reachability.swift.Implementation Details 🚧
This PR adds a
WeakManagertype to wrap a weak reference to theNetworkReachabilityManagerand updates the context memory management closures to properly retain and release the values.Testing Details 🔍
No tests added, wasn't able to find a way to trigger the reported crash. Since this logic matches that of the other popular reachability library I'm confident it's correct.