Add Debates engine #9

ItsGenis · 2017-01-18T14:51:04Z

🎩 What? Why?

Fixes #3

👻 GIF

houndci-bot · 2017-01-18T14:51:15Z

engines/decidim-debates/spec/spec_helper.rb

@@ -0,0 +1,2 @@
+ENV["ENGINE_NAME"] = File.dirname(File.dirname(__FILE__)).split("/").last


Missing frozen string literal comment.

houndci-bot · 2017-01-18T14:51:15Z

engines/decidim-debates/spec/shared/manage_meetings_examples.rb

+  it "creates a new meeting" do
+    find(".actions .new").click
+
+    within ".new_meeting" do


Block has too many lines. [41/25]

houndci-bot · 2017-01-18T14:51:15Z

engines/decidim-debates/spec/shared/manage_meetings_examples.rb

+    end
+  end
+
+  it "creates a new meeting" do


Block has too many lines. [50/25]

houndci-bot · 2017-01-18T14:51:15Z

engines/decidim-debates/spec/shared/manage_meetings_examples.rb

@@ -0,0 +1,121 @@
+# -*- coding: utf-8 -*-
+# frozen_string_literal: true
+RSpec.shared_examples "manage meetings" do


Block has too many lines. [99/25]

houndci-bot · 2017-01-18T14:51:16Z

engines/decidim-debates/spec/shared/admin_shared_context.rb

@@ -0,0 +1,11 @@
+RSpec.shared_context "admin" do


Missing frozen string literal comment.

houndci-bot · 2017-01-18T14:51:16Z

engines/decidim-debates/spec/services/meeting_search_spec.rb

+        let(:params) { default_params.merge(scope_id: [scope2.id, scope1.id]) }
+
+        it "filters meetings by scope" do
+          expect(subject.results).to match_array [meeting1,meeting2]


Space missing after comma.

houndci-bot · 2017-01-18T14:51:16Z

engines/decidim-debates/spec/services/meeting_search_spec.rb

+    end
+  end
+
+  describe "filters" do


Block has too many lines. [56/25]

houndci-bot · 2017-01-18T14:51:17Z

engines/decidim-debates/spec/services/meeting_search_spec.rb

+      let(:default_params) { { feature: nil } }
+
+      it "raises an error" do
+        expect{ subject.results }.to raise_error(StandardError, "Missing feature")


Space missing to the left of {.

houndci-bot · 2017-01-18T14:51:17Z

engines/decidim-debates/spec/services/meeting_search_spec.rb

@@ -0,0 +1,135 @@
+require "spec_helper"
+
+describe Decidim::Meetings::MeetingSearch do


Block has too many lines. [108/25]

houndci-bot · 2017-01-18T14:51:17Z

engines/decidim-debates/spec/services/meeting_search_spec.rb

@@ -0,0 +1,135 @@
+require "spec_helper"


Missing frozen string literal comment.

houndci-bot · 2017-01-18T14:51:17Z

engines/decidim-debates/spec/forms/meeting_form_spec.rb

+
+require "spec_helper"
+
+describe Decidim::Meetings::Admin::MeetingForm do


Block has too many lines. [99/25]

houndci-bot · 2017-01-18T14:51:18Z

engines/decidim-debates/spec/forms/meeting_form_spec.rb

@@ -0,0 +1,133 @@
+# frozen_literal_string: true


Missing frozen string literal comment.

houndci-bot · 2017-01-18T14:51:18Z

engines/decidim-debates/spec/features/explore_meetings_spec.rb

+    end
+  end
+
+  context "show" do


Block has too many lines. [61/25]

houndci-bot · 2017-01-18T14:51:18Z

engines/decidim-debates/spec/features/explore_meetings_spec.rb

+      expect(page).to have_selector("article.card", count: meetings_count)
+
+      meetings.each do |meeting|
+        expect(page).to have_content(translated meeting.title)


Add parentheses to nested method call translated meeting.title.

houndci-bot · 2017-01-18T14:51:19Z

engines/decidim-debates/spec/features/explore_meetings_spec.rb

@@ -0,0 +1,107 @@
+require "spec_helper"
+
+describe "Explore meetings", type: :feature do


Block has too many lines. [89/25]

houndci-bot · 2017-01-18T14:51:19Z

engines/decidim-debates/spec/features/explore_meetings_spec.rb

@@ -0,0 +1,107 @@
+require "spec_helper"


Missing frozen string literal comment.

houndci-bot · 2017-01-23T09:37:43Z

engines/decidim-debates/spec/shared/manage_debates_examples.rb

+  it "creates a new debate" do
+    find(".actions .new").click
+
+    within ".new_debate" do


Block has too many lines. [40/25]

houndci-bot · 2017-01-23T09:37:43Z

engines/decidim-debates/spec/shared/manage_debates_examples.rb

+    end
+  end
+
+  it "creates a new debate" do


Block has too many lines. [49/25]

houndci-bot · 2017-01-23T09:37:43Z

engines/decidim-debates/spec/shared/manage_debates_examples.rb

@@ -0,0 +1,120 @@
+# -*- coding: utf-8 -*-
+# frozen_string_literal: true
+RSpec.shared_examples "manage debates" do


Block has too many lines. [98/25]

houndci-bot · 2017-01-23T09:37:44Z

engines/decidim-debates/spec/services/debate_search_spec.rb

+    end
+  end
+
+  describe "filters" do


Block has too many lines. [35/25]

houndci-bot · 2017-01-23T09:37:44Z

engines/decidim-debates/spec/services/debate_search_spec.rb

+      let(:default_params) { { feature: nil } }
+
+      it "raises an error" do
+        expect{ subject.results }.to raise_error(StandardError, "Missing feature")


Space missing to the left of {.

houndci-bot · 2017-01-23T09:37:44Z

engines/decidim-debates/spec/services/debate_search_spec.rb

@@ -0,0 +1,104 @@
+require "spec_helper"
+
+describe Decidim::Debates::DebateSearch do


Block has too many lines. [83/25]

houndci-bot · 2017-01-23T09:37:44Z

engines/decidim-debates/spec/services/debate_search_spec.rb

@@ -0,0 +1,104 @@
+require "spec_helper"


Missing frozen string literal comment.

houndci-bot · 2017-01-23T09:37:44Z

engines/decidim-debates/spec/forms/debate_form_spec.rb

+
+require "spec_helper"
+
+describe Decidim::Debates::Admin::DebateForm do


Block has too many lines. [99/25]

houndci-bot · 2017-01-23T09:37:45Z

engines/decidim-debates/spec/forms/debate_form_spec.rb

@@ -0,0 +1,133 @@
+# frozen_literal_string: true


Missing frozen string literal comment.

One of this things is not like the other

houndci-bot · 2017-01-23T09:37:45Z

engines/decidim-debates/spec/factories.rb

@@ -0,0 +1,12 @@
+require "decidim/core/test/factories"


Missing frozen string literal comment.

houndci-bot · 2017-01-23T09:37:45Z

engines/decidim-debates/spec/commands/update_meeting_spec.rb

+      description: {en: "description"},
+      short_description: {en: "short_description"},
+      location: {en: "location"},
+      location_hints: {en: "location_hints"},


Space inside { missing.
Space inside } missing.

houndci-bot · 2017-01-23T09:37:45Z

engines/decidim-debates/spec/commands/update_meeting_spec.rb

+      title: {en: "title"},
+      description: {en: "description"},
+      short_description: {en: "short_description"},
+      location: {en: "location"},


Space inside { missing.
Space inside } missing.

houndci-bot · 2017-01-23T09:37:46Z

engines/decidim-debates/spec/commands/update_meeting_spec.rb

+      :invalid? => invalid,
+      title: {en: "title"},
+      description: {en: "description"},
+      short_description: {en: "short_description"},


Space inside { missing.
Space inside } missing.

mrcasals · 2017-01-27T14:16:18Z

engines/decidim-debates/spec/forms/debate_form_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # frozen_literal_string: true


Remove this one

oriolgual · 2017-01-27T14:09:38Z

engines/decidim-debates/app/controllers/decidim/debates/debates_controller.rb

+
+      helper_method :debates, :debate
+
+      def index; end


You don't need if there's a view named index

oriolgual · 2017-01-27T14:10:15Z

engines/decidim-debates/app/forms/decidim/debates/admin/debate_form.rb

+        validates :current_feature, presence: true
+        validates :category, presence: true, if: ->(form) { form.decidim_category_id.present? }
+
+        def scope


Should we validate the scope like category?

It has no scope, this has to be removed.

oriolgual · 2017-01-27T14:10:26Z

engines/decidim-debates/app/forms/decidim/debates/admin/debate_form.rb

+        validates :start_time, presence: true, date: { before: :end_time }
+        validates :end_time, presence: true, date: { after: :start_time }
+
+        validates :current_feature, presence: true


The current feature is automatically injected, no need to validate.

oriolgual · 2017-01-27T14:11:39Z

engines/decidim-debates/app/models/decidim/debates/debate.rb

+      validate :author_belongs_to_organization
+      validates :title, presence: true
+
+      def author_name


I'd remove the author name from here & the views. Debates are only created by admins so it makes no sense.

oriolgual · 2017-01-27T14:11:49Z

engines/decidim-debates/app/models/decidim/debates/debate.rb

+        user_group&.name || author&.name || I18n.t("decidim.debates.models.debate.fields.official_debate")
+      end
+
+      def author_avatar_url


oriolgual · 2017-01-27T14:15:56Z

engines/decidim-debates/app/views/decidim/debates/debates/show.html.erb

+      </div>
+      <div class="author-data__extra">
+        <a href="#comments" title="<%= t('.comments') %>">
+          <%= icon "comment-square", aria_label: t('.comments'), role: "img" %> <%= Decidim::Comments::Comment.where(commentable: debate).count %>


I'd add a relation at debate, something like:

has_many :comments, as: :commentable

So you can just do debate.comments.count

/cc @josepjaume @beagleknight

oriolgual · 2017-01-27T14:16:50Z

db/migrate/20170127093544_create_debates.decidim_debates.rb

@@ -0,0 +1,18 @@
+# This migration comes from decidim_debates (originally 20170118141619)
+class CreateDebates < ActiveRecord::Migration[5.0]


Remove this file, it belongs to the engine.

oriolgual · 2017-01-27T14:18:13Z

engines/decidim-debates/decidim-debates.gemspec

+  s.description = s.summary
+  s.version     = "0.0.1"
+  s.authors     = ["Josep Jaume Rey Peroy", "Marc Riera Casals", "Oriol Gual Oliva", "Genís Matutes Pujol"]
+  s.email       = ["josepjaume@gmail.com", "mrc2407@gmail.com", "oriolgual@gmail.com", "genis.matutes@gmail.com"]


Version, authors & email aren't necessary

That's actually, wrong? Can't remember when but I was forced to put them in to use the engine.

It's not wrong but we've omitted these so it "inherits" it from the main gem, which is the only one published.

oriolgual · 2017-01-27T14:18:38Z

engines/decidim-debates/decidim-debates.gemspec

+
+  s.files = Dir["{app,config,db,lib}/**/*", "Rakefile", "README.md"]
+
+  s.add_dependency "decidim-core"


s.add_dependency "decidim-core", Decidim.version

Add comments too:
s.add_dependency "decidim-comments", Decidim.version

oriolgual · 2017-01-27T14:20:24Z

engines/decidim-debates/spec/forms/debate_form_spec.rb

@@ -0,0 +1,133 @@
+# frozen_literal_string: true


One of this things is not like the other

* Add Debates engine WIP [ci-skip] * Remove scopes * Bump, get tests ready * Finish bumping unit tests * WIP [ci-skip] * Use real index markup * More markup WIP [ci-skip] * Add instructions * Add comments and fix markup * Add missing translations * Pass rubocop * Remove DS_Store files * Remove authorable from debates * Reviewd stuff * Rebase * Fix stuff

houndci-bot reviewed Jan 18, 2017

View reviewed changes

engines/decidim-debates/spec/shared/manage_meetings_examples.rb

end

end

it "creates a new meeting" do

Copy link

houndci-bot Jan 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [50/25]

houndci-bot reviewed Jan 18, 2017

View reviewed changes

engines/decidim-debates/spec/services/meeting_search_spec.rb

end

end

describe "filters" do

Copy link

houndci-bot Jan 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [56/25]

houndci-bot reviewed Jan 18, 2017

View reviewed changes

engines/decidim-debates/spec/features/explore_meetings_spec.rb

end

end

context "show" do

Copy link

houndci-bot Jan 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [61/25]

houndci-bot reviewed Jan 18, 2017

View reviewed changes

ItsGenis force-pushed the feature/debates-engine branch from 540aa99 to 8b02ad5 Compare January 23, 2017 09:37

houndci-bot reviewed Jan 23, 2017

View reviewed changes

engines/decidim-debates/spec/shared/manage_debates_examples.rb

end

end

it "creates a new debate" do

Copy link

houndci-bot Jan 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [49/25]

houndci-bot reviewed Jan 23, 2017

View reviewed changes

engines/decidim-debates/spec/services/debate_search_spec.rb

end

end

describe "filters" do

Copy link

houndci-bot Jan 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [35/25]

houndci-bot reviewed Jan 23, 2017

View reviewed changes

engines/decidim-debates/spec/factories.rb

@@ -0,0 +1,12 @@

require "decidim/core/test/factories"

Copy link

houndci-bot Jan 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

houndci-bot reviewed Jan 23, 2017

View reviewed changes

ItsGenis force-pushed the feature/debates-engine branch 2 times, most recently from 0d51b5e to 41e83d0 Compare January 27, 2017 14:04

ItsGenis changed the title ~~Add Debates engine [WIP]~~ Add Debates engine Jan 27, 2017

mrcasals approved these changes Jan 27, 2017

View reviewed changes

oriolgual suggested changes Jan 27, 2017

View reviewed changes

ItsGenis force-pushed the feature/debates-engine branch 2 times, most recently from a7fee0c to ceb4102 Compare January 27, 2017 14:45

ItsGenis requested a review from beagleknight January 27, 2017 14:45

ItsGenis force-pushed the feature/debates-engine branch from ceb4102 to d51c5a2 Compare January 27, 2017 14:48

oriolgual approved these changes Jan 27, 2017

View reviewed changes

ItsGenis added 16 commits January 27, 2017 16:31

Add Debates engine WIP [ci-skip]

54f52de

Remove scopes

6aaebb6

Bump, get tests ready

9c31afc

Finish bumping unit tests

d3d2b44

WIP [ci-skip]

005496b

Use real index markup

54cb390

More markup WIP [ci-skip]

9f64e26

Add instructions

500916f

Add comments and fix markup

6b3f261

Add missing translations

4d98226

Pass rubocop

933a932

Remove DS_Store files

e420983

Remove authorable from debates

60845ca

Reviewd stuff

3c32584

Rebase

af8aab3

Fix stuff

ddfd257

ItsGenis force-pushed the feature/debates-engine branch from a39547c to ddfd257 Compare January 27, 2017 15:31

oriolgual merged this pull request into master Jan 27, 2017

oriolgual deleted the feature/debates-engine branch January 27, 2017 16:01

		@@ -0,0 +1,2 @@
		ENV["ENGINE_NAME"] = File.dirname(File.dirname(__FILE__)).split("/").last

		@@ -0,0 +1,135 @@
		require "spec_helper"

		describe Decidim::Meetings::MeetingSearch do


		require "spec_helper"

		describe Decidim::Meetings::Admin::MeetingForm do

		@@ -0,0 +1,107 @@
		require "spec_helper"

		describe "Explore meetings", type: :feature do

		@@ -0,0 +1,104 @@
		require "spec_helper"

		describe Decidim::Debates::DebateSearch do


		require "spec_helper"

		describe Decidim::Debates::Admin::DebateForm do

		@@ -1,3 +1,4 @@
		# frozen_string_literal: true
		# frozen_literal_string: true

		@@ -0,0 +1,18 @@
		# This migration comes from decidim_debates (originally 20170118141619)
		class CreateDebates < ActiveRecord::Migration[5.0]


		s.files = Dir["{app,config,db,lib}/*/", "Rakefile", "README.md"]

		s.add_dependency "decidim-core"

Add Debates engine #9

Add Debates engine #9

Conversation

ItsGenis commented Jan 18, 2017 • edited Loading

🎩 What? Why?

👻 GIF

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ItsGenis Jan 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ItsGenis commented Jan 18, 2017 •

edited

Loading

ItsGenis Jan 27, 2017 •

edited

Loading