Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rake task to remove old notifications #575

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Rake task to remove old notifications #575

merged 1 commit into from
Nov 21, 2024

Conversation

fblupi
Copy link
Contributor

@fblupi fblupi commented Nov 12, 2024

🎩 What? Why?

Rake task to remove old notifications.

📌 Related Issues

  • Related to DECIDIM-996

@fblupi fblupi requested review from davidbeig and HHassig November 12, 2024 11:55
HHassig
HHassig approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@HHassig HHassig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and thorough.

davidbeig
davidbeig reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@davidbeig davidbeig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fblupi I have left some comments where i would like to understand more about this solution.

Thanks for the work done!

lib/tasks/notifications.rake Show resolved Hide resolved
lib/tasks/notifications.rake Show resolved Hide resolved
@fblupi fblupi merged commit c7be9fb into master Nov 21, 2024
5 checks passed
@fblupi fblupi deleted the feat/notifications-removal-task branch November 21, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbeig davidbeig davidbeig left review comments

@HHassig HHassig HHassig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fblupi @HHassig @davidbeig