-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verification data export page in stats module #552
Add verification data export page in stats module #552
Conversation
I managed to add the @furilo There might not be enough verifications data to export, do you want me to create some? |
@NilHomedes In our staging we don't have the verification method used in decidim-barcelona (app/services/census_authorization_handler.rb), so when exporting the data, you'll miss the fields that doesn't match the metadata structure. To fully test this we could try to configure your authorization method to our staging or, in case you have a staging server, we could deploy the export data page there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the translations, the rest looks ok to me
Hi @mllocs
Yes, that could be the best way to test this module. Take into account that Barcelona is using different authorizations handlers:
By the way, I leave a couple of things I have seen:
So the question is: This module would work for any type of authorizations handler? Or it will only works for Barcelona's authorizations? |
@furilo @NilHomedes which icon do you suggest to use for "Export data"? https://nightly.decidim.org/design/foundations/iconography |
I guess |
Or |
This is because the "Example Authorization" doesn't even store the birthday as a metadata 🤷 https://github.com/decidim/decidim/blob/develop/decidim-generators/lib/decidim/generators/app_templates/dummy_authorization_handler.rb#L72 |
It will work for authorizations that store the metadata the same way Barcelona's authorizations do. |
@mllocs Thanks for the explanation, now it's clearer to me. |
…celona into feat/add-verifications-export-page-to-stats-module
@NilHomedes I tried it in decidim-barcelona's staging, this is what I found:
|
@fblupi I added a commit fixing one little thing, could you redeploy please? |
@mllocs I've just deployed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected, thanks @mllocs 💯
I'm approving this to move it forward.
Just one suggestion, could you document this new feature in the Readme module?
🎩 What? Why?
On some occasions, it is necessary to know the sociodemographic data of the participants in a process. Currently, this data can be obtained from the verification form. That is, if you ask for the date of birth, gender, and postal code during the verification, you can then aggregate this data to know the sociodemographic profile of the participants.
📌 Related Issues
📷 Screenshots (optional)