Rename the name 'slack-connector' to 'slack' #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small proposal that would propably be easier to apply early on. When writing connector, the names are like following: kafka, upsert-kafka, jdbc, elasticsearch-7 and so on (no connector postfix) having the -connector postfix here feels redundant proposing to just call it 'slack', so when writing a table it becomes: 'connector' = 'slack'
|
This is naturally a breaking change, but I'd recommend doing it. |
snuyanzin
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small proposal that would propably be easier to apply early on.
When using a connector, the names are like following:
kafka, upsert-kafka, jdbc, elasticsearch-7 and so on (no
-connectorpostfix).Having the -connector postfix here feels redundant.
Proposing to just call it 'slack', so when writing the connector name in the CREATE TABLE statement, it would be written as:
'connector' = 'slack'instead of'connector' = 'slack-connector'