Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OvenPlayer fetch null #388

Merged
merged 11 commits into from
Oct 19, 2023
Merged

Fix OvenPlayer fetch null #388

merged 11 commits into from
Oct 19, 2023

Conversation

dygy
Copy link
Contributor

@dygy dygy commented Oct 14, 2023

@dygy
Copy link
Contributor Author

dygy commented Oct 17, 2023

@SangwonOh

SangwonOh
SangwonOh reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@SangwonOh SangwonOh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think testing is needed.

src/js/api/media/Manager.js Show resolved Hide resolved
@dygy dygy requested a review from SangwonOh October 18, 2023 18:14
SangwonOh
SangwonOh approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@SangwonOh SangwonOh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! 👍

@SangwonOh SangwonOh merged commit db59c4f into AirenSoft:master Oct 19, 2023
@dygy dygy deleted the fix/fetch-null branch October 19, 2023 16:46
@SangwonOh SangwonOh mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SangwonOh SangwonOh SangwonOh approved these changes

@henb henb henb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dygy @henb @SangwonOh