Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: seek back/forward 10s on double tap #379

Merged
merged 2 commits into from
Oct 13, 2023
Merged

feat: seek back/forward 10s on double tap #379

merged 2 commits into from
Oct 13, 2023

Conversation

hernanrz
Copy link
Contributor

@hernanrz hernanrz commented Oct 3, 2023 •
edited
Loading

My implementation for #371 , looking forward to your feedback, thanks!

@SangwonOh SangwonOh self-requested a review October 5, 2023 13:35
@dygy
Copy link
Contributor

dygy commented Oct 5, 2023

are you sure it should be enabled by default? I guess it's good feature to be enablable

@hernanrz
Copy link
Contributor Author

hernanrz commented Oct 5, 2023

That's a good point, it can be made into an opt-in feature, I'll update the branch later today

@dygy
Copy link
Contributor

dygy commented Oct 5, 2023

i just imagined my stakeholders to say they don't want this feature :DDDD

SangwonOh
SangwonOh requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@SangwonOh SangwonOh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hernanrz I'll wait for you to change this feature to enable it as an option. Thank you very much for your contribution 👍

@hernanrz hernanrz force-pushed the feat/double-tap-to-seek branch from d01a48a to fed4057 Compare October 12, 2023 03:39
@hernanrz hernanrz force-pushed the feat/double-tap-to-seek branch from fed4057 to a5c0616 Compare October 12, 2023 03:42
SangwonOh
SangwonOh approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@SangwonOh SangwonOh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!
This feature will be added v0.10.32

@SangwonOh SangwonOh merged commit 44599ba into AirenSoft:master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SangwonOh SangwonOh SangwonOh approved these changes

@dygy dygy dygy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hernanrz @dygy @SangwonOh