Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Payment Service entities and commands #25

Merged
merged 30 commits into from
Apr 21, 2024

Conversation

AhmedNasserG
Copy link
Collaborator

@AhmedNasserG AhmedNasserG commented Mar 24, 2024

  • Move services logic to commands

AhmedNasserG and others added 2 commits March 24, 2024 02:52
Co-authored-by: Abdulaziz-Hassan <abdulazizhza@gmail.com>
Co-authored-by: Abdulaziz-Hassan <abdulazizhza@gmail.com>
@AhmedNasserG AhmedNasserG linked an issue Mar 24, 2024 that may be closed by this pull request
3 tasks
@Abdulaziz-Hassan Abdulaziz-Hassan changed the title Added wallet model entity, repository, service, and controller Add Wallet model entity, repository, service, and controller Mar 24, 2024
@AhmedNasserG AhmedNasserG changed the title Add Wallet model entity, repository, service, and controller Add Wallet and Payment Request model entities, repositories, services, and controllers Mar 24, 2024
@AhmedNasserG AhmedNasserG linked an issue Mar 24, 2024 that may be closed by this pull request
3 tasks
marsafy1

This comment was marked as outdated.

@Abdulaziz-Hassan

This comment was marked as outdated.

@marsafy1

This comment was marked as outdated.

@Abdulaziz-Hassan Abdulaziz-Hassan changed the title Add Wallet and Payment Request model entities, repositories, services, and controllers Add Payment Service entities and commands Apr 19, 2024
@Abdulaziz-Hassan Abdulaziz-Hassan linked an issue Apr 19, 2024 that may be closed by this pull request
3 tasks
Copy link
Owner

@Ahmad45123 Ahmad45123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for shared folder. Just small nit which you can fix now or later. From my tests JsonDeserialize crashed the server when used with SuperBuilder.

Abdulaziz-Hassan and others added 2 commits April 21, 2024 21:55
…aymentTransactionDTO.java

Co-authored-by: Ahmed Elwasefi <a.m.elwasefi@gmail.com>
…alletTransactionDTO.java

Co-authored-by: Ahmed Elwasefi <a.m.elwasefi@gmail.com>
@Abdulaziz-Hassan Abdulaziz-Hassan self-requested a review April 21, 2024 21:00
@Abdulaziz-Hassan Abdulaziz-Hassan merged commit 2e3991c into main Apr 21, 2024
2 checks passed
@Abdulaziz-Hassan Abdulaziz-Hassan deleted the payments-add-wallet-model branch April 21, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants