-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Payment Service entities and commands #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AhmedNasserG
commented
Mar 24, 2024
•
edited by Abdulaziz-Hassan
Loading
edited by Abdulaziz-Hassan
- Move services logic to commands
Co-authored-by: Abdulaziz-Hassan <abdulazizhza@gmail.com>
Co-authored-by: Abdulaziz-Hassan <abdulazizhza@gmail.com>
3 tasks
3 tasks
3 tasks
AhmedNasserG
commented
Mar 24, 2024
...s/payments/src/main/java/com/workup/payments/wallettransaction/WalletTransactionService.java
Outdated
Show resolved
Hide resolved
services/payments/src/main/java/com/workup/payments/wallettransaction/WalletTransaction.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
3 tasks
Ahmad45123
approved these changes
Apr 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for shared folder. Just small nit which you can fix now or later. From my tests JsonDeserialize
crashed the server when used with SuperBuilder.
shared/src/main/java/com/workup/shared/commands/payments/dto/PaymentTransactionDTO.java
Outdated
Show resolved
Hide resolved
shared/src/main/java/com/workup/shared/commands/payments/dto/WalletTransactionDTO.java
Outdated
Show resolved
Hide resolved
…aymentTransactionDTO.java Co-authored-by: Ahmed Elwasefi <a.m.elwasefi@gmail.com>
…alletTransactionDTO.java Co-authored-by: Ahmed Elwasefi <a.m.elwasefi@gmail.com>
Abdulaziz-Hassan
requested changes
Apr 21, 2024
...c/main/java/com/workup/payments/commands/paymentrequest/GetClientPaymentRequestsCommand.java
Show resolved
Hide resolved
...in/java/com/workup/payments/commands/paymentrequest/GetFreelancerPaymentRequestsCommand.java
Show resolved
Hide resolved
...ents/src/main/java/com/workup/payments/commands/paymentrequest/PayPaymentRequestCommand.java
Outdated
Show resolved
Hide resolved
...ava/com/workup/payments/commands/paymenttransaction/GetClientPaymentTransactionsCommand.java
Show resolved
Hide resolved
...com/workup/payments/commands/paymenttransaction/GetFreelancerPaymentTransactionsCommand.java
Show resolved
Hide resolved
services/payments/src/main/java/com/workup/payments/commands/wallet/CreateWalletCommand.java
Show resolved
Hide resolved
...rc/main/java/com/workup/payments/commands/wallettransaction/GetWalletTransactionCommand.java
Show resolved
Hide resolved
...c/main/java/com/workup/payments/commands/wallettransaction/GetWalletTransactionsCommand.java
Show resolved
Hide resolved
.../src/main/java/com/workup/payments/commands/wallettransaction/WithdrawFromWalletCommand.java
Outdated
Show resolved
Hide resolved
services/payments/src/main/java/com/workup/payments/models/PaymentRequest.java
Outdated
Show resolved
Hide resolved
Abdulaziz-Hassan
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.