Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Caching for findByEmail and fixed the bug with email uniquness #102

Merged
merged 5 commits into from
May 18, 2024
Merged

Added Caching for findByEmail and fixed the bug with email uniquness #102

merged 5 commits into from
May 18, 2024

Conversation

ShimaaBetah
Copy link
Collaborator

  • configured redis cache
  • Added caching for findByEmail using @cachable annotation
  • Edited tests to add redis container
  • Fixed bug with mail uniqueness when registering

Pandemic1617
Pandemic1617 approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@Pandemic1617 Pandemic1617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small detail for production deployment, otherwise LGTM

@ShimaaBetah ShimaaBetah merged commit 9fa0f03 into main May 18, 2024
2 checks passed
@ShimaaBetah ShimaaBetah deleted the cached-users branch May 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandemic1617 Pandemic1617 Pandemic1617 approved these changes

@MahmoudHosamGaber MahmoudHosamGaber Awaiting requested review from MahmoudHosamGaber MahmoudHosamGaber is a code owner

@Akram-Fahim Akram-Fahim Awaiting requested review from Akram-Fahim Akram-Fahim is a code owner

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShimaaBetah @Pandemic1617 @Ahmad45123