This repository has been archived by the owner on May 3, 2024. It is now read-only.
chore: use new amountMath #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
michaelfig
approved these changes
Apr 17, 2021
|
Ok, thanks, @michaelfig! Can you tell me more about "Note that this pr will have to be merged with agoric-sdk/packages/pegasus and the dapp-pegasus/contract directory importing it from there."? I've been making the necessary changes to the rest of agoric-sdk as well: Agoric/agoric-sdk#2894. Is it that the code needs to be copied over from this repo to agoric-sdk? Or the other way around? Or is it just testing compatibility? I'll wait on merging this in until I understand more. No rush on this. Thanks! |
|
@michaelfig, based on our conversation, I can merge this in, right? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use only the new amountMath