[Zoe] Allow sparse keywords #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9834f8c to
912bdb7
Compare
Chris-Hibbert
requested changes
Apr 1, 2020
| // Return the keys after asserting this. | ||
| const checkKeys = (expectedKeys, record) => { | ||
| // Assert that keys, if present, match expectedKeys. | ||
| export const assertCapASCII = keyword => { |
There was a problem hiding this comment.
cleanProposal.js is exporting a few things that aren't covered by the current name. Would it be better to rename it, or to split its functions up further?
The comment above no longer covers the file, so it should be moved closer to the function it describes. (Or the fn moved up here if it doesn't depend on the other fns.)
There was a problem hiding this comment.
Yeah, I'm not sure how to split up the content of this file versus objArrayConversion.js. They are both more generalized helpers now.
I will move that comment!
Chris-Hibbert
approved these changes
Apr 2, 2020
2 tasks
2bb06e3 to
03cd094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reviewing, let's make sure this implementation matches the "spec" outlined in this issue: #800
Closes #800
Closes #393
Closes #785
Closes #849
Closes partially #847