Simplify Creation of parameter declarations #4005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dtribble suggested this simplification from #3448 while it was under review.
Description
These helper functions reduce the call to declare a governed parameter from
to
which is a pretty substantial reduction for the first thing that a contract author has to do to add governed parameters.
Security Considerations
Nothing substantial. This doesn't change the API for controlling parameters, and it reduces complexity for readers.
Documentation Considerations
We need more thorough documentation for how contract developers can add governance, but this PR simplifies the task to be explained.
Testing Considerations
None.