Claims registar suggestions #3932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than mapping over .keys() and looking up each key
Chris-Hibbert
added a commit
that referenced
this pull request
Oct 7, 2021
more handles have capitalized names than not. Suggestions from #3932
|
I incorporated these changes into #3622, not always the way you intended. |
Chris-Hibbert
added a commit
that referenced
this pull request
Oct 7, 2021
more handles have capitalized names than not. Suggestions from #3932
Chris-Hibbert
added a commit
that referenced
this pull request
Oct 7, 2021
more handles have capitalized names than not. Suggestions from #3932
Chris-Hibbert
added a commit
that referenced
this pull request
Oct 7, 2021
more handles have capitalized names than not. Suggestions from #3932
Chris-Hibbert
added a commit
that referenced
this pull request
Oct 7, 2021
more handles have capitalized names than not. Suggestions from #3932
mergify bot
added a commit
that referenced
this pull request
Oct 8, 2021
* feat!: use contractGovernor to govern Treasury using ParamManager extract params to a separate file integrate contract governance into treasury swingset test for treasury governance closes #3189 closes #3473 * chore: minor cleanups: drop extra logs, standardize asserts, tsc fix * chore: improve typescript declarations * feat: add noAction electorate for assurance of no governance changes * chore: validate() in test checks the installations * fix: import types.js into params so bundle is usable in tests * feat!: add a claimsRegistrar based on attestations Agents who can deposit an attestation payment will get the ability to vote that amount. refactor common registrat code to a library tests that BinaryBallotCounter can count these votes. * chore: review sugestions: types, cleanups, comments * chore: better type decls, capitalize handles more handles have capitalized names than not. Suggestions from #3932 * fix: remove spurious distinction in naming of Liquidity keyword * fix: handle<'attestation'> ==> Handle<'Attestation'> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a bunch of suggestions for #3622
one is somewhat substantive: