Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups #3408

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Minor cleanups #3408

merged 3 commits into from
Jun 25, 2021

Conversation

michaelfig
Copy link
Member

I noticed these minor problems, and bundled them up into a single PR:

  • Golang abstracts away some signals under the name os.Interrupt, which we should also catch
  • The faucet was not given urun when bootstrapping a new chain
  • faucet-helper.sh was falling through and reporting a misleading error
  • Add some leftovers from the XS snapshot tests to .gitignore.

@michaelfig michaelfig added deployment Chain deployment mechanism (e.g. testnet) hygiene Tidying up around the house labels Jun 25, 2021
@michaelfig michaelfig self-assigned this Jun 25, 2021
@michaelfig michaelfig requested review from kriskowal and dckc June 25, 2021 00:50
dckc
dckc reviewed Jun 25, 2021
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know a bit more about the urun thing.

packages/xsnap/.gitignore Show resolved Hide resolved
packages/deployment/ansible/cosmos-genesis.yml Show resolved Hide resolved
@michaelfig michaelfig merged commit 5b38615 into master Jun 25, 2021
@michaelfig michaelfig deleted the mfig-more-cleanups branch June 25, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc approved these changes

@kriskowal kriskowal Awaiting requested review from kriskowal

Assignees

@michaelfig michaelfig

Labels
deployment Chain deployment mechanism (e.g. testnet) hygiene Tidying up around the house
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelfig @dckc