Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agorictest-6 deployment fixes #2493

Merged
merged 4 commits into from
Feb 21, 2021
Merged

agorictest-6 deployment fixes #2493

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2fed3b
fix: remove journalbeat from build; it fails and we don't use it
michaelfig Feb 17, 2021
8afd58b
fix: properly docker push agoric/deployment:$(TAG)
michaelfig Feb 17, 2021
db75f65
fix: be tolerant of delegation errors
michaelfig Feb 19, 2021
7e45aa4
feat: bump to cosmos-sdk v0.41.1
michaelfig Feb 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/deployment/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ docker-push-solo:

docker-push-deployment:
$(DONT_PUSH_LATEST) docker push agoric/deployment:latest
docker push $(REPOSITORY)-solo:$(TAG)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what did this used to do? how was it even close?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortunately, the old code was never executed (instead the .github/workflows/docker.yml built and tagged the images). I ran into this only because journalbeat failed to compile in the Github action, and I needed to push the images manually.

Which upon inspection wasn't pushing the agoric/deployment tag as I expected. So I fixed it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was introduced as part of a refactoring to fix a prior refactoring.

docker push agoric/deployment:$(TAG)