1568 Make Zoe use AVA #1588
Merged
1568 Make Zoe use AVA #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd4e5de to
45015dc
Compare
|
Ok @katelynsills , I've had three successful test runs with that ESM_DISABLE_CACHE patch, so I'm hoping the problem is fixed. Handing this back to you for rebasing and landing. |
|
@warner, wonderful, thanks so much! |
…ejection Removed unnecessary console.error(), cleaned up types
Chris-Hibbert
approved these changes
Aug 27, 2020
Chris-Hibbert
requested changes
Aug 27, 2020
| @@ -298,12 +268,12 @@ const expectedBadTimerLog = [ | |||
| 'aliceMoolaPurse: balance {"brand":{},"value":3}', | |||
| 'aliceSimoleanPurse: balance {"brand":{},"value":0}', | |||
| ]; | |||
| test('zoe - bad timer', async t => { | |||
| test.skip('zoe - bad timer', async t => { | |||
There was a problem hiding this comment.
There should be an issue for this, and there should be a TODO here referring to the issue.
There was a problem hiding this comment.
There is an issue. #1625 I will add TODOs
Chris-Hibbert
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1568
Kate: All tests pass. Most recent changes to tests were caused by @Chris-Hibbert's changes to the autoswap tests. Chris could you take a look at test-autoswap.js specifically?