feat: adaptors between notifiers and async iterables #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of @Chris-Hibbert 's review comments on #1334 , have yet to:
@michaelfig I'm adding you as reviewer, but really seeking this help. Thanks. Also, I need to add tests of the async iterable functionality. |
5150595 to
24627e0
Compare
|
@michaelfig and I will be meeting so he can get me started on the typing. Aside from that, this PR is ready for review, so I'm hitting the button ;) |
24627e0 to
2f95803
Compare
|
Back to draft while I fix a bug. |
2f95803 to
2dfa829
Compare
Chris-Hibbert
approved these changes
Jul 29, 2020
michaelfig
reviewed
Jul 29, 2020
c1d983e to
1bac700
Compare
1bac700 to
eb08d1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An adapter from notifiers to async iterables.
An adapter from async iterables to notifiers.
notifiers are also async iterables.
Replaces #1334 but based on current master rather than branch remove-legacy-from-notifier
I'm rearranging this so the async iterable adaptors can proceed before we remove legacy support, since the removal entails inter-repository coordination.