Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet should create a feePurse and apply it to Zoe so that a user can pay fees #3669

Closed
katelynsills opened this issue Aug 12, 2021 · 0 comments
Closed

Wallet should create a feePurse and apply it to Zoe so that a user can pay fees #3669

katelynsills opened this issue Aug 12, 2021 · 0 comments
Assignees
@michaelfig
Labels
enhancement New feature or request wallet Zoe package: Zoe
Milestone
Testnet: Metering...

Comments

@katelynsills
Copy link
Contributor

For the user to be able to pay fees, the user's wallet needs to have a feePurse with RUN in it.

In #3663, Zoe will be changed to take a feePurse as the first argument to install, offer, startInstance, and getPublicFacet. #3663 has a method applyFeePurse which partially applies a feePurse, producing the original Zoe API.

When Zoe is passed to the wallet, the wallet should:

  1. Make a feePurse with E(zoe).getFeePurse()
  2. Add the feePurse to the user's list of purses
  3. Allow the user to transfer RUN to the feePurse (this should fall out of purse functionality in the wallet)
  4. Apply the feePurse to Zoe, so that the Zoe that the wallet interacts with is the one with the feePurse applied.
@katelynsills katelynsills added enhancement New feature or request Zoe package: Zoe wallet labels Aug 12, 2021
@katelynsills katelynsills added this to the Testnet: Metering Phase milestone Aug 12, 2021
michaelfig added a commit that referenced this issue Aug 13, 2021
@michaelfig
feat(wallet): register a fee purse and forward invitationDetails
2a637ce 
Closes #3669
michaelfig added a commit that referenced this issue Aug 13, 2021
@michaelfig
feat(wallet): set up a Zoe fee purse and forward invitationDetails
cc27390 
Closes #3669
michaelfig added a commit that referenced this issue Aug 13, 2021
@michaelfig
feat(wallet): set up a Zoe fee purse and forward invitationDetails
3670127 
Closes #3669
@michaelfig michaelfig mentioned this issue Aug 13, 2021
Merged
michaelfig added a commit that referenced this issue Aug 14, 2021
@michaelfig
feat(wallet): set up a Zoe fee purse and forward invitationDetails
bc5bb21 
Closes #3669
katelynsills pushed a commit that referenced this issue Aug 14, 2021
@michaelfig @katelynsills
feat(wallet): set up a Zoe fee purse and forward invitationDetails
d92bef2 
Closes #3669
katelynsills pushed a commit that referenced this issue Aug 14, 2021
@michaelfig @katelynsills
feat(wallet): set up a Zoe fee purse and forward invitationDetails
eca914e 
Closes #3669
michaelfig added a commit that referenced this issue Aug 16, 2021
@michaelfig
feat(wallet): set up a Zoe fee purse and forward invitationDetails
f7b11e6 
Closes #3669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelfig michaelfig

Labels
enhancement New feature or request wallet Zoe package: Zoe
Projects
None yet
Milestone
Testnet: Metering Phase
Development

No branches or pull requests
2 participants
@michaelfig @katelynsills