Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer device throws errors when clock doesn't yet advance #328

Closed
michaelfig opened this issue Dec 12, 2019 · 0 comments · Fixed by #329
Closed

Timer device throws errors when clock doesn't yet advance #328

michaelfig opened this issue Dec 12, 2019 · 0 comments · Fixed by #329
Labels
SwingSet package: SwingSet

Comments

@michaelfig
Copy link
Member

The SwingSet timer device has a check to ensure every poll() call advances the clock. However, it is conceivable, given coarse timer granularity that a poll() call happens twice with the same timestamp, and indeed, I have seen this in #322.

We should probably relax the monotonicity requirement so that the timer is still restricted from moving backwards, but can be poll()ed with a non-advancing timestamp.
@michaelfig michaelfig added the SwingSet package: SwingSet label Dec 12, 2019
michaelfig added a commit that referenced this issue Dec 12, 2019
@michaelfig
fix(timer): don't enforce timer advancement, just prevent moving back…
e67826c 
…wards

Also update docs/timer.md to document timer vat API.

Closes #328
michaelfig added a commit that referenced this issue Dec 12, 2019
@michaelfig
fix(timer): don't enforce advancement, just prevent moving backwards
7a0a509 
Also update docs/timer.md to document timer vat API.

Closes #328
@michaelfig michaelfig mentioned this issue Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SwingSet package: SwingSet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(timer): don't enforce advancement, just prevent moving backwards Agoric/agoric-sdk
1 participant
@michaelfig