Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulnerability: getInterfaceOf doesn't fully validate, but passStyleOf believes it #2435

Closed
erights opened this issue Feb 16, 2021 · 0 comments · Fixed by #2460
Closed

Vulnerability: getInterfaceOf doesn't fully validate, but passStyleOf believes it #2435

erights opened this issue Feb 16, 2021 · 0 comments · Fixed by #2460
Assignees
@erights
Labels
bug Something isn't working security

Comments

@erights
Copy link
Member

erights commented Feb 16, 2021

I introduced a vulnerability in #2361 . I knew getInterfaceOf did not do a full validation. But I reasoned that this is ok because anyone needing a full validation should call passStyleOf. I forgot that passStyleOf calls getInterfaceOf and short circuits if it returns something.
@erights erights added the bug Something isn't working label Feb 16, 2021
@erights erights self-assigned this Feb 16, 2021
erights added a commit that referenced this issue Feb 18, 2021
@erights
fix: #2435 make getInterfaceOf truthful
28e21b6
@erights erights mentioned this issue Feb 18, 2021
Merged
erights added a commit that referenced this issue Feb 18, 2021
@erights
fix: #2435 make getInterfaceOf truthful
19c8c1a
erights added a commit that referenced this issue Feb 22, 2021
@erights
fix: #2435 make getInterfaceOf truthful
29936b6
michaelfig pushed a commit that referenced this issue Apr 26, 2021
@erights @michaelfig
fix: #2435 make getInterfaceOf truthful
4f6b154
michaelfig pushed a commit that referenced this issue Apr 26, 2021
@erights @michaelfig
fix: #2435 make getInterfaceOf truthful
e58d493
michaelfig pushed a commit that referenced this issue Apr 26, 2021
@erights @michaelfig
fix(marshal): #2435 make getInterfaceOf truthful
94b6d50
michaelfig pushed a commit that referenced this issue Apr 27, 2021
@erights @michaelfig
fix(marshal): #2435 make getInterfaceOf truthful
5ab98a6
michaelfig pushed a commit that referenced this issue Apr 27, 2021
@erights @michaelfig
fix(marshal): #2435 make getInterfaceOf truthful
a69a3bd
michaelfig pushed a commit that referenced this issue Apr 27, 2021
@erights @michaelfig
fix(marshal): #2435 make getInterfaceOf truthful
ff19f93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erights erights

Labels
bug Something isn't working security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make getInterfaceOf truthful Agoric/agoric-sdk
1 participant
@erights