Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userSeat.hasExited has wrong logic #1729

Closed
katelynsills opened this issue Sep 9, 2020 · 0 comments
Closed

userSeat.hasExited has wrong logic #1729

katelynsills opened this issue Sep 9, 2020 · 0 comments
Assignees
Labels
bug Something isn't working Zoe package: Zoe

Comments

@katelynsills
Copy link
Contributor

Describe the bug

As @Chris-Hibbert discovered, userSeat.hasExited currently has the wrong logic.

It should be corrected:

Screen Shot 2020-09-09 at 1 45 17 PM

@katelynsills katelynsills added bug Something isn't working Zoe package: Zoe labels Sep 9, 2020
Chris-Hibbert added a commit that referenced this issue Sep 11, 2020
revive some zoeHelper tests

Turning eslint back on required cleaning up a bunch of dead code.
add some tests for the swap helper
using the contract that exports zcf
move setupZCFTest to a common location and share it.
use makeOffer helper suggested by Kate

fixes: #1729
Chris-Hibbert added a commit that referenced this issue Sep 11, 2020
This is mostly test updates, but it fixes one actual bug

fixes: #1729

revive some zoeHelper tests
zoeHelper trade with same handle
Turning eslint back on required cleaning up a bunch of dead code.
@katelynsills katelynsills self-assigned this Sep 14, 2020
Chris-Hibbert added a commit that referenced this issue Sep 14, 2020
This is mostly test updates, but it fixes one actual bug

fixes: #1729

revive some zoeHelper tests
zoeHelper trade with same handle
Turning eslint back on required cleaning up a bunch of dead code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Zoe package: Zoe
Projects
None yet
Development

No branches or pull requests

1 participant