Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeWorker cannot syscall.callNow #1617

Closed
dckc opened this issue Aug 25, 2020 · 1 comment
Closed

nodeWorker cannot syscall.callNow #1617

dckc opened this issue Aug 25, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request SwingSet package: SwingSet

Comments

@dckc
Copy link
Member

dckc commented Aug 25, 2020

context: #1407 (comment)

cc @warner

@dckc dckc added the enhancement New feature or request label Aug 25, 2020
@warner
Copy link
Member

warner commented Sep 1, 2020

I will add a test case for this

@warner warner self-assigned this Sep 1, 2020
@warner warner added the SwingSet package: SwingSet label Sep 16, 2020
warner added a commit that referenced this issue Jan 19, 2021
This is the only type of worker which can currently handle syscall.callNow.

The `node-subprocess` case theoretically could (the child subprocess could do a
blocking read of the kernel-to-worker pipe while waiting for the result), but
the code on either side of that pipe does not yet support that mode.

The `nodeWorker` (Node.js threads) case cannot, because threads cannot block,
at least not without heroics involving `Atomic` locks around a
results-bearing `SharedArrayBuffer`.

The old `xs-worker` case could not, for the same shallow implementation
reasons as `node-subprocess`, but the new `xsnap` -based XS worker should be
capable.

closes #1617
dckc pushed a commit that referenced this issue Jan 21, 2021
This is the only type of worker which can currently handle syscall.callNow.

The `node-subprocess` case theoretically could (the child subprocess could do a
blocking read of the kernel-to-worker pipe while waiting for the result), but
the code on either side of that pipe does not yet support that mode.

The `nodeWorker` (Node.js threads) case cannot, because threads cannot block,
at least not without heroics involving `Atomic` locks around a
results-bearing `SharedArrayBuffer`.

The old `xs-worker` case could not, for the same shallow implementation
reasons as `node-subprocess`, but the new `xsnap` -based XS worker should be
capable.

closes #1617
@dckc dckc closed this as completed in c3c489e Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SwingSet package: SwingSet
Projects
None yet
Development

No branches or pull requests

2 participants