misuse of config.hostStorage in a swingset unit test

[warner]

One of the dynamic vat tests is using a pattern which I think is wrong, but I'm not sure:

agoric-sdk/packages/SwingSet/test/vat-admin/test-innerVat.js

Lines 12 to 14 in a3bf3cd

	async function doTestSetup(mode) {
	const config = await loadBasedir(__dirname);
	config.hostStorage = initSwingStore().storage;

@FUDCo I think you currently know the most about hostStorage, so I wanted to check my hunch: config.hostStorage is ignored, and storage should be passed throughruntimeOptions (third argument to buildVatController). Is that correct?

Should we just delete this config.hostStorage = line? The test doesn't need to do anything special with storage, it can use ephemeral RAM.

Please reassign back to me if that's the case, and I'll make the PR to remove it.

[FUDCo]

Yup, I think your intuitions are correct. I somehow missed this one when I was upgrading everything to the new config model. Simply deleting the line and falling back on the default ephemeral store is fine (since that's effectively what now happens anyway when this is run).

[FUDCo]

Fixed by #1686