Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes needed before publishing v0.0.1 #123

Closed
michaelfig opened this issue Jun 24, 2019 · 5 comments
Closed

changes needed before publishing v0.0.1 #123

michaelfig opened this issue Jun 24, 2019 · 5 comments
Labels
eventual-send package: eventual-send

Comments

@michaelfig
Copy link
Member

@erights, would you please do a review of this package?

Let's track any required changes before the first test release here, and spin-off separate issues when they can be postponed until after the initial NPM release.

When the code is good enough for a v0.0.1 release, we'll close this issue.

@michaelfig
Copy link
Member Author

Notably, I don't have any tests for EPromise.makeRemote. Can you illustrate a sample usage?

@erights
Copy link
Member

erights commented Jun 24, 2019

Can you illustrate a sample usage?

Based on https://github.com/tvcutsem/es-lab/blob/master/src/ses/makeFarResourceMaker.js
See also https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch

function makeFetcher(url) {
  return harden({
    GET(p, key) {
      return fetch(`${url}&q=${key}`);
    },
  };
}

@erights
Copy link
Member

erights commented Jun 24, 2019

I am having a hard time understanding the iteration stuff starting at
https://github.com/Agoric/eventual-send/blob/master/src/index.js#L98

@michaelfig
Copy link
Member Author

I was at least twice as clever as I should have been. I've rewritten that part to use a combinePromises function instead, which is closer in semantics to reduce and thus may be easier to understand.

@michaelfig
Copy link
Member Author

As @erights said in Agoric/eventual-send#7, this is good enough to release a v0.0.1. A detailed review will come later.

@warner warner transferred this issue from Agoric/eventual-send Dec 4, 2019
@warner warner added the eventual-send package: eventual-send label Dec 4, 2019
dckc pushed a commit to dckc/agoric-sdk that referenced this issue Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eventual-send package: eventual-send
Projects
None yet
Development

No branches or pull requests

3 participants