fix: detect extra syscalls in replay

Agoric · May 11, 2021 · 6b6f837 · 6b6f837
1 parent d6c1de6
commit 6b6f837
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/SwingSet/src/kernel/vatManager/manager-helper.js b/packages/SwingSet/src/kernel/vatManager/manager-helper.js
@@ -164,6 +164,7 @@ function makeManagerKit(
       });
       // eslint-disable-next-line no-await-in-loop
       await deliver(t.d);
+      transcriptManager.finishReplayDelivery();
       kernelSlog.write({ type: 'finish-replay-delivery', vatID, deliveryNum });
       deliveryNum += 1;
     }

diff --git a/packages/SwingSet/src/kernel/vatManager/transcript.js b/packages/SwingSet/src/kernel/vatManager/transcript.js
@@ -59,6 +59,22 @@ export function makeTranscriptManager(vatKeeper, vatID) {
     return s.response;
   }
 
+  function finishReplayDelivery() {
+    if (playbackSyscalls.length !== 0) {
+      console.log(`anachrophobia strikes vat ${vatID}`);
+      console.log(
+        `delivery completed with ${playbackSyscalls.length} expected syscalls remaining`,
+      );
+      for (const s of playbackSyscalls) {
+        console.log(`expected:`, djson.stringify(s.d));
+      }
+      if (!replayError) {
+        replayError = new Error(`historical inaccuracy in replay of ${vatID}`);
+      }
+      throw replayError;
+    }
+  }
+
   function checkReplayError() {
     if (replayError) {
       throw replayError;
@@ -73,6 +89,7 @@ export function makeTranscriptManager(vatKeeper, vatID) {
     startReplayDelivery,
     finishReplay,
     simulateSyscall,
+    finishReplayDelivery,
     checkReplayError,
     inReplay,
   });