Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AgoraVideoView crash when dispose after RtcEngine.release #1585

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

littleGnAl
Copy link
Contributor

@littleGnAl littleGnAl commented Feb 23, 2024

The IrisRtcEngineRendering handle becomes invalid after RtcEngine.release, which needs explicit clean-up of the texture renderers on the native side.

Fix #1567

@littleGnAl littleGnAl changed the title [WIP] fix: AgoraVideoView crash when dispose after RtcEngine.release fix: AgoraVideoView crash when dispose after RtcEngine.release Feb 26, 2024
@littleGnAl littleGnAl changed the title fix: AgoraVideoView crash when dispose after RtcEngine.release [WIP]fix: AgoraVideoView crash when dispose after RtcEngine.release Feb 26, 2024
@littleGnAl littleGnAl force-pushed the littlegnal/fix-dispose-crash branch 3 times, most recently from b03d19a to de7f3ce Compare March 4, 2024 03:15
@littleGnAl littleGnAl changed the title [WIP]fix: AgoraVideoView crash when dispose after RtcEngine.release fix: AgoraVideoView crash when dispose after RtcEngine.release Mar 4, 2024
@littleGnAl littleGnAl force-pushed the littlegnal/fix-dispose-crash branch from de7f3ce to fe6410c Compare March 5, 2024 03:29
@littleGnAl littleGnAl merged commit cd33120 into main Mar 5, 2024
35 checks passed
@littleGnAl littleGnAl deleted the littlegnal/fix-dispose-crash branch March 5, 2024 10:31
peilinok pushed a commit that referenced this pull request Sep 2, 2024
The `IrisRtcEngineRendering` handle becomes invalid after
`RtcEngine.release`, which needs explicit clean-up of the texture
renderers on the native side.

Fix #1567
peilinok pushed a commit that referenced this pull request Sep 2, 2024
The `IrisRtcEngineRendering` handle becomes invalid after
`RtcEngine.release`, which needs explicit clean-up of the texture
renderers on the native side.

Fix #1567
littleGnAl added a commit that referenced this pull request Sep 6, 2024
The `IrisRtcEngineRendering` handle becomes invalid after
`RtcEngine.release`, which needs explicit clean-up of the texture
renderers on the native side.

Fix #1567
littleGnAl added a commit that referenced this pull request Sep 13, 2024
The `IrisRtcEngineRendering` handle becomes invalid after
`RtcEngine.release`, which needs explicit clean-up of the texture
renderers on the native side.

Fix #1567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[windows] agora in secondary window crashes app if window is closed
1 participant