added forceRequestLocation flag and detect no No location provider available #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have updated the PR to include detection of "No location provider available". |
|
Thanks for the PR, I'll look into it asap. |
|
@Agontuk Any reason this PR hasn't been merged in yet? |
|
@jkreish to be honest, I still haven't been able to properly review this PR. I have some free time now, so I'll take a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where "Improve Location accuracy" is Off on Android O+, it is still possible to use just the GPS to retrieve locations.
To cover those scenarios, I have added a flag to allow requesting a location even though the SETTINGS_NOT_SATISFIED error was raised.
That will allow trying to request a location even though the user has clicked "Deny" on the Improve Location Request modal.