Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc readability value-prop updates #288

Merged
merged 27 commits into from
Jul 20, 2024
Merged

Conversation

albertkimjunior
Copy link
Contributor

📥 Pull Request

📘 Description
See introduction.mdx

🔄 Related Issue (if applicable)
If this PR is related to an existing issue, reference it here.

🎯 Goal
Explain the intention behind this change.

🔍 Additional Context
Any extra information or context to help us understand the change?

🧪 Testing
Describe the tests you performed to validate your changes.

Thank you for your contribution to Agentops!

@albertkimjunior albertkimjunior requested a review from areibman July 6, 2024 00:31
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 42.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@albertkimjunior
Copy link
Contributor Author

albertkimjunior commented Jul 19, 2024

@areibman this change that directs users to their dashboard to "Get API Key" will be a lot more seamless if AgentOps app login supports persistent URL path linking/deep linking
Screenshot 2024-07-19 at 11 18 04 AM

@areibman areibman enabled auto-merge (squash) July 20, 2024 15:39
Copy link

gitguardian bot commented Jul 20, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12083425 Triggered Generic High Entropy Secret 667c52f tests/core_manual_tests/agentchat_agentops.ipynb View secret
12083425 Triggered Generic High Entropy Secret 667c52f tests/core_manual_tests/agentchat_agentops.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@areibman areibman merged commit b20f533 into main Jul 20, 2024
8 of 10 checks passed
@areibman areibman deleted the doc-readability-valueprop-updates branch July 20, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants