[Bugfix] Use Data Protection service name that matches the Adyen::Client#service_url_base
#209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpaul
approved these changes
Dec 15, 2023
wboereboom
approved these changes
Dec 18, 2023
Merged
|
Hello @wboereboom When can we expect the release of that change as a patch to 7.0.* version? I've seen it only included in 8 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run
.data_protection.request_subject_erasure({ merchantAccount: 'blurred', pspReference: 'blorred' })the service throwsArgumentError: Invalid service specified.Looking into the source code I found out that this was caused by
Adyen::Client#service_url_baseexpecting "DataProtectionService". However inAdyen::DataProtection->initialize, the "DataProtection" string was used as a service name.