New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log file not written in 1.1.2 #197

Closed

dpiddockcmp opened this issue Jul 17, 2019 · 1 comment

dpiddockcmp commented Jul 17, 2019

Commit 8d635c3 removed the use of the log file. This wasn't mentioned as part of the PR or release notes.

Please could the log file be restored? The config loading code wasn't modified and the example configs still imply the log file is used.

If removing the log file was intentional please:

emit warnings when LogFile or LogMessages: true in the config file so that users are aware of the change
give more flexibility in selecting output log level. debug is too noisy and the default of warning does not display messages.
remove variables from sample configs

The text was updated successfully, but these errors were encountered:

p4tin added a commit that referenced this issue


          #197 Fix Logging issues

p4tin added a commit that referenced this issue


          Merge pull request #207 from p4tin/loggingFixes

7aca39e

#197 Fix Logging issues

Collaborator

p4tin commented Oct 5, 2019

Fixed in v0.2.2

p4tin closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment