Legitimate URL Shortener filter #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-302
approved these changes
Jul 12, 2021
slavaleleka
reviewed
Jul 12, 2021
| "timeAdded": 1626086804599, | ||
| "homepage": "https://github.com/DandelionSprout/adfilt", | ||
| "expires": "4 days", | ||
| "displayNumber": 251, |
There was a problem hiding this comment.
this parameter will make this filter the last in privacy group. are you sure it's should be after fanboy's filters?
There was a problem hiding this comment.
Well, I was just thinking about it. In the end, this is a safe option, but if it is in front of EasyPrivacy, then next to our AdGuard URL Tracking filter.
slavaleleka
requested changes
Jul 12, 2021
| { | ||
| "filterId": 251, | ||
| "name": "Legitimate URL Shortener", | ||
| "description": "In a world dominated by bit.ly, ad.fly, and several thousand other malware cover-up tools, this list reduces the length of URLs in a much more legitimate and transparent manner. Essentially, it automatically removes unnecessary $/& values from the URLs, making them easier to copy from the URL bar and pasting elsewhere as links.", |
There was a problem hiding this comment.
$/& should be replaced:
'$' and '&'
There was a problem hiding this comment.
Ok, I'll replace it.
slavaleleka
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#401
According to this post #401 (comment), I excluded some platforms.