-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve parser #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest to write like this
or short versions
It is recommended not to use prefix "I" in the interface name |
maximtop
approved these changes
Nov 28, 2022
Ok, thanks. I will make these changes.
|
This is a relatively large commit, sorry.
The linter shows no problems and the tests run. |
maximtop
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor modifications based on previous reviews.
TODO:
@maximtop How do I handle the examples below? Should they follow the "Ublock" pattern too? I think uBO is named inconsistently in a few more places. This should be unified in this PR.
AGLint/src/utils/adblockers.ts
Lines 5 to 10 in 9701b56
AGLint/src/parser/cosmetic/specific/ubo-options.ts
Line 14 in 9701b56
AGLint/src/parser/cosmetic/specific/ubo-options.ts
Line 18 in 9701b56
AGLint/src/parser/cosmetic/specific/ubo-options.ts
Line 48 in 9701b56