Clean up further memory leaks around filters #15
Closed
+6,781
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow widget definitions to include a "focusOnCreate" flag which tells the widget whether or not to grab focus immediately after being created. This flag defaults to true, which is the same as the previous behavior. Closes #6
We're loading this library eagerly in prod environments and there is no body element yet.
This bumps deps to match what they are upstream at SHA b1562f4. It makes the build script compatible with Node 8.
From ckeditor#2969 Excludes changes to: * plugins/widget/plugin.js - change can't apply cleanly. * plugins/autocomplete/plugin.js - file doesn't exist on this version.
Implements most of ckeditor#1770
|
Moot as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements most of ckeditor#1770
Needs a smoke test in an app to confirm.