Fix: yarn start #1814
Merged
Fix: yarn start #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a description to this PR explaining the fix please? I'd like to understand the context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I upgraded the dependencies of the "new-client" and I also added a commit for leveraging one of the new utils of
@react-rxjs/utils. After each change I made sure that the production build was working properly and I did check whether we were having improvements on the Lighthouse metrics or not, and everything was working fine.However, a few hours later I got messages from @iprado78 and from Julie letting me know that the
yarn startscript was no longer working:The error on the image doesn't make any sense, because optional chaining it's in stage-4, it's supported by the current LTS version of node and I don't see any reason why the
esmbuild of a modern library shouldn't be using it these days. Also, this problem only happens on the "dev" build, not on the prod build... So, I was really puzzled about this. First I thought about changing the target of the esm build of react-rxjs toes2019, but that felt wrong. So, after digging into this a lot more I found that this is a long standing issue of CRA: facebook/create-react-app#9468, facebook/create-react-app#9749 .A work-around is to use the same
browserslistfor both production and development, which is what this commit does.