Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating palette base color token type for better type safety #222

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

bheston
Copy link
Member

@bheston bheston commented Aug 9, 2024

Pull Request

Description

Added the palette base colors as css tokens so they are also available in styling. Using a base color directly is not the core use case of the Adaptive UI color model because it does not convey the semantic intent behind a derived color, but there are valid cases for this.

The plumbing requires this to be a Color and not a hex string.

Test Plan

Tested in Designer plugin

Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation for this project.

@bheston bheston self-assigned this Aug 12, 2024
@bheston bheston merged commit 6834958 into main Aug 13, 2024
3 checks passed
@bheston bheston deleted the users/bheston/designer-base-color branch August 13, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant