Designer: Added ability to mark a node inline
for styling
#217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
In Figma we often build components from smaller components. In some cases those are actual implemented components, like a Button, but sometimes they are just convenience for construction in Figma.
The
inline
configuration option added to a node here allows us to mark a component as a construction utility and "inline" it into the components where it's used for style processing. The concrete example of this is a Label component which has the label text node and a required indicator node. It's unlikely we will write an actual Label component, rather that this is just an attribute or slot of a handful of implemented components. We can now mark that inline and components like a Text Filed, Select, etc. will be able to process styling for the label elements.The alternative is that the instance in Figma is an actual published component, but we don't have the ability to detect that full list, so we assume that they are as this is more common.
Test Plan
Tested in CLI.
Checklist
General