Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer: Added ability to mark a node inline for styling #217

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

bheston
Copy link
Member

@bheston bheston commented Jul 18, 2024

Pull Request

Description

In Figma we often build components from smaller components. In some cases those are actual implemented components, like a Button, but sometimes they are just convenience for construction in Figma.

The inline configuration option added to a node here allows us to mark a component as a construction utility and "inline" it into the components where it's used for style processing. The concrete example of this is a Label component which has the label text node and a required indicator node. It's unlikely we will write an actual Label component, rather that this is just an attribute or slot of a handful of implemented components. We can now mark that inline and components like a Text Filed, Select, etc. will be able to process styling for the label elements.

The alternative is that the instance in Figma is an actual published component, but we don't have the ability to detect that full list, so we assume that they are as this is more common.

Test Plan

Tested in CLI.

Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation for this project.

@bheston bheston self-assigned this Jul 18, 2024
@bheston bheston merged commit 85f1e62 into main Jul 19, 2024
3 checks passed
@bheston bheston deleted the users/bheston/designer-inline-node branch July 19, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants