Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUI: Update CLI from tokens to align with existing properties #216

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

bheston
Copy link
Member

@bheston bheston commented Jul 15, 2024

Pull Request

Description

Aligning the naming and of the properties associated with a style rule. Originally in AUI these were "properties" but in the json anatomy we initially only supported token values so we called them "tokens". As we continue to reconcile the models it's better to call them the same thing.

Test Plan

Tested in AUI CLI.

Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation for this project.

Copy link
Collaborator

@nicholasrice nicholasrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will we need to re-generate anatomy json files after this change?

@bheston bheston merged commit 270e484 into main Jul 16, 2024
3 checks passed
@bheston bheston deleted the users/bheston/aui-cli-tokens-to-properties branch July 16, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants