-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CLI module imports on windows #209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which node version are you running? I'm on 18.17.1 on Windows and it's been working when I run |
I'm on 21 |
@bheston I have now tested on latest node version in both windows and Unix environments and the change added in this PR works across all the tested environments. |
Tested on Mac, seems to be working. |
nicholasrice
approved these changes
Jul 2, 2024
bheston
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR fixes an issue in the CLI when running in a Windows environment. The node implementation of
import
only works withfile://
anddata://
urls and not Windows file paths so this PR usespathToFileURL
to wrap theinputFilePath
and convert it into a file url if it isn't already.Issues
Reviewer Notes
@bheston
@nicholasrice
I won't be able to test on a Macbook for several hours so if either of you review this before then and would like to test this branch on a Unix environment, feel free.
Test Plan
Checklist
General
Component-specific
⏭ Next Steps