Fixing a few CLI runtime issues #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingOfTac
approved these changes
May 30, 2024
nicholasrice
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
The Designer CLI wasn't working on Windows, related to a shell script not executing correctly. Added a parameter that fixes this, but haven't tested on mac.
Added some error messaging since I was running into errors with my config but the messages weren't being displayed.
Reviewer Notes
Open to suggestions on the error handling. I went for the least obtrusive solution I could find.
Test Plan
Tested on Windows. Please validate on mac.
Checklist
General